Skip to content

feat: link frontend to backend for guests#220

Merged
zaydaanjahangir merged 25 commits intomainfrom
feat/129-link-geusts-frontend-to-backend
Apr 10, 2026
Merged

feat: link frontend to backend for guests#220
zaydaanjahangir merged 25 commits intomainfrom
feat/129-link-geusts-frontend-to-backend

Conversation

@zaydaanjahangir
Copy link
Copy Markdown
Contributor

@zaydaanjahangir zaydaanjahangir commented Mar 27, 2026 •
edited
Loading

Description

Linking backend guests to frontend web

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Closes #
Related to #

What Changed?

  • Cleaned up the API contract (backend models + swagger) to align with most recent backend changes

Testing & Validation

How this was tested

  1. Tested locally
  2. Added a couple unit tests for specific behaviors

Screenshots/Recordings

Notes & Nuances

  • Filter for group size on backend only is for 5-20 rather than 5+ on designs, updated the FE to show 5-20 but will need to fix later

Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 55.66502% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.78%. Comparing base (a72a798) to head (06514b3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/repository/guests.go 18.96% 47 Missing ⚠️
...ients/web/src/components/guests/GuestNotesCard.tsx 0.00% 12 Missing ⚠️
clients/web/src/hooks/use-debounce.ts 0.00% 9 Missing ⚠️
...ts/web/src/components/guests/PreviousStaysCard.tsx 0.00% 8 Missing ⚠️
...nts/web/src/components/guests/GuestProfileCard.tsx 77.41% 7 Missing ⚠️
clients/web/src/utils/dates.ts 62.50% 3 Missing ⚠️
...eb/src/components/guests/GuestSpecialNeedsCard.tsx 33.33% 2 Missing ⚠️
.../web/src/components/guests/GuestQuickListTable.tsx 97.22% 1 Missing ⚠️
.../components/guests/HousekeepingPreferencesCard.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #220       +/-   ##
==========================================
+ Coverage   0.53%   10.78%   +10.24%     
==========================================
  Files         88      145       +57     
  Lines       4089     6527     +2438     
  Branches       0       36       +36     
==========================================
+ Hits          22      704      +682     
- Misses      4067     5807     +1740     
- Partials       0       16       +16
Flag Coverage Δ
backend 18.71% <20.33%> (?)
mobile 84.00% <ø> (?)
web 5.20% <70.13%> (+4.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/guests.go 97.46% <100.00%> (ø)
backend/internal/models/guests.go 0.00% <ø> (ø)
...src/components/guests/GuestProfilePageSkeleton.tsx 100.00% <100.00%> (ø)
...ents/web/src/routes/_protected/guests.$guestId.tsx 20.00% <100.00%> (+20.00%) ⬆️
clients/web/src/routes/_protected/guests.index.tsx 20.00% <100.00%> (+20.00%) ⬆️
.../web/src/components/guests/GuestQuickListTable.tsx 98.71% <97.22%> (+98.71%) ⬆️
.../components/guests/HousekeepingPreferencesCard.tsx 5.26% <50.00%> (ø)
...eb/src/components/guests/GuestSpecialNeedsCard.tsx 3.12% <33.33%> (+0.34%) ⬆️
clients/web/src/utils/dates.ts 62.50% <62.50%> (ø)
...nts/web/src/components/guests/GuestProfileCard.tsx 87.03% <77.41%> (+87.03%) ⬆️
... and 4 more

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zaydaanjahangir zaydaanjahangir marked this pull request as ready for review March 31, 2026 22:21
Dao-Ho
Dao-Ho requested changes Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, this is a great ship overall!!

@zaydaanjahangir zaydaanjahangir requested a review from Dao-Ho April 4, 2026 16:21
@danctila danctila added the feature Introduces a new and complete feature label Apr 7, 2026
Dao-Ho
Dao-Ho requested changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left cmts

@zaydaanjahangir zaydaanjahangir requested a review from Dao-Ho April 10, 2026 00:22
Dao-Ho
Dao-Ho approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@zaydaanjahangir zaydaanjahangir merged commit 92fa9f1 into main Apr 10, 2026
16 checks passed
@zaydaanjahangir zaydaanjahangir deleted the feat/129-link-geusts-frontend-to-backend branch April 10, 2026 02:56
Dao-Ho added a commit that referenced this pull request Apr 10, 2026
@Dao-Ho
Revert "feat: link frontend to backend for guests (#220)"
5d7d7c2 
This reverts commit 92fa9f1.
@Dao-Ho Dao-Ho mentioned this pull request Apr 10, 2026
Merged
Dao-Ho added a commit that referenced this pull request Apr 10, 2026
@Dao-Ho
Revert "feat: link frontend to backend for guests (#220)" (#312)
212b220 
This reverts commit 92fa9f1.
@zaydaanjahangir zaydaanjahangir restored the feat/129-link-geusts-frontend-to-backend branch April 10, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dao-Ho Dao-Ho Dao-Ho approved these changes

Assignees

@zaydaanjahangir zaydaanjahangir

Labels

changes requested feature Introduces a new and complete feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zaydaanjahangir @Dao-Ho @danctila